cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

filter bookings by event type

Open hussamkhatib opened this issue 2 years ago • 7 comments

What does this PR do?

Fixes #4013 Related: #6099

https://github.com/calcom/cal.com/assets/52914487/2796a2be-ffc3-4dcb-ac43-4f4fc8f45cc3

Type of change

  • New feature (non-breaking change which adds functionality) The Checkbox component logs a error when the state is changed

A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component.

How should this be tested?

  • Before trying out the filter, make sure there are few event types and booking.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

hussamkhatib avatar May 20 '23 21:05 hussamkhatib

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 1:55am

vercel[bot] avatar May 20 '23 21:05 vercel[bot]

@hussamkhatib is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 20 '23 21:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.58 KB 406.51 KB 116.15% (🟢 -0.18%)
/apps 275.79 KB 426.72 KB 121.92% (🟢 -0.90%)
/apps/[slug] 293.74 KB 444.67 KB 127.05% (🟢 -0.90%)
/apps/[slug]/[...pages] 456.7 KB 607.63 KB 173.61% (🟢 -0.33%)
/apps/categories 238.17 KB 389.1 KB 111.17% (🟢 -0.90%)
/apps/categories/[category] 258.99 KB 409.92 KB 117.12% (🟢 -0.90%)
/apps/installed/[category] 276.71 KB 427.64 KB 122.18% (🟢 -0.44%)
/auth/login 149.41 KB 300.34 KB 85.81% (🟢 -0.18%)
/auth/setup 174.77 KB 325.7 KB 93.06% (🟡 +0.16%)
/availability 243.49 KB 394.42 KB 112.69% (🟢 -0.90%)
/availability/[schedule] 331.01 KB 481.94 KB 137.70% (🟢 -0.53%)
/availability/troubleshoot 238.86 KB 389.79 KB 111.37% (🟢 -0.90%)
/bookings/[status] 339.16 KB 490.09 KB 140.02% (🟢 -0.41%)
/d/[link]/book 255.23 KB 406.16 KB 116.04% (🟢 -0.17%)
/event-types 425.6 KB 576.53 KB 164.72% (🟢 -0.52%)
/event-types/[type] 478.15 KB 629.08 KB 179.74% (🟢 -0.36%)
/insights 447.01 KB 597.94 KB 170.84% (🟢 -0.49%)
/more 237.79 KB 388.72 KB 111.06% (🟢 -0.90%)
/new-booker/[user]/[type] 290.67 KB 441.6 KB 126.17% (🟢 -0.21%)
/new-booker/team/[slug]/[type] 290.67 KB 441.6 KB 126.17% (🟢 -0.21%)
/settings/admin 243.38 KB 394.31 KB 112.66% (🟢 -0.88%)
/settings/admin/apps 255.06 KB 405.99 KB 116.00% (🟢 -0.78%)
/settings/admin/apps/[category] 255.05 KB 405.98 KB 115.99% (🟢 -0.77%)
/settings/admin/flags 246.06 KB 396.99 KB 113.43% (🟢 -0.89%)
/settings/admin/impersonation 243.66 KB 394.59 KB 112.74% (🟢 -0.88%)
/settings/admin/users 244.8 KB 395.73 KB 113.07% (🟢 -0.88%)
/settings/admin/users/[id]/edit 332.07 KB 483 KB 138.00% (🟢 -0.56%)
/settings/admin/users/add 331.75 KB 482.68 KB 137.91% (🟢 -0.56%)
/settings/billing 243.52 KB 394.45 KB 112.70% (🟢 -0.88%)
/settings/developer/api-keys 272.13 KB 423.06 KB 120.87% (🟢 -0.88%)
/settings/developer/webhooks 246.53 KB 397.46 KB 113.56% (🟢 -0.88%)
/settings/developer/webhooks/[id] 249.57 KB 400.5 KB 114.43% (🟢 -0.51%)
/settings/developer/webhooks/new 249.42 KB 400.35 KB 114.39% (🟢 -0.52%)
/settings/my-account/appearance 257.88 KB 408.81 KB 116.80% (🟢 -0.84%)
/settings/my-account/calendars 251.16 KB 402.09 KB 114.88% (🟢 -0.54%)
/settings/my-account/conferencing 249.08 KB 400.01 KB 114.29% (🟢 -0.90%)
/settings/my-account/general 325.47 KB 476.4 KB 136.12% (🟢 -0.57%)
/settings/my-account/profile 371.43 KB 522.36 KB 149.24% (🟢 -0.71%)
/settings/security/impersonation 245.34 KB 396.27 KB 113.22% (🟢 -0.88%)
/settings/security/password 256.06 KB 406.99 KB 116.28% (🟢 -0.48%)
/settings/security/sso 252.88 KB 403.81 KB 115.37% (🟢 -0.88%)
/settings/security/two-factor-auth 247.74 KB 398.67 KB 113.91% (🟢 -0.89%)
/settings/teams 243.15 KB 394.08 KB 112.59% (🟢 -0.88%)
/settings/teams/[id]/appearance 257.7 KB 408.63 KB 116.75% (🟢 -0.88%)
/settings/teams/[id]/billing 243.39 KB 394.32 KB 112.66% (🟢 -0.88%)
/settings/teams/[id]/members 357.11 KB 508.04 KB 145.16% (🟢 -0.62%)
/settings/teams/[id]/onboard-members 160.82 KB 311.75 KB 89.07% (🟢 -0.91%)
/settings/teams/[id]/profile 366.39 KB 517.32 KB 147.81% (🟢 -0.89%)
/settings/teams/[id]/sso 252.98 KB 403.91 KB 115.40% (🟢 -0.88%)
/settings/teams/new 182.42 KB 333.35 KB 95.24% (🟢 -1.29%)
/team/[slug]/book 255.23 KB 406.16 KB 116.05% (🟢 -0.18%)
/teams 237.88 KB 388.81 KB 111.09% (🟢 -0.90%)
/workflows 250.74 KB 401.67 KB 114.76% (🟢 -0.90%)
/workflows/[workflow] 367.09 KB 518.02 KB 148.01% (🟢 -0.52%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 20 '23 21:05 github-actions[bot]

Tagging @Jaibles as I don't think we have as design for this yet

CarinaWolli avatar May 22 '23 06:05 CarinaWolli

@hussamkhatib can you check the two most recent comments?

PeerRich avatar May 23 '23 09:05 PeerRich

CleanShot 2023-05-23 at 10 25 46@2x I dont see any issue with the filters bar being scrollable when on mobile honestly. Happy with how this is currently. Would like the issue i mentioned to be fixed before merging tho

sean-brydon avatar May 23 '23 09:05 sean-brydon

@PeerRich I did see them, I thought I need to wait for @Jaibles for the design. I'll fix the issue mentioned by @sean-brydon.

hussamkhatib avatar May 23 '23 10:05 hussamkhatib

Hey @sean-brydon, Can I know which tool did you use for viewing multiple screens at once ? ref: https://github.com/calcom/cal.com/pull/9011#issuecomment-1558898764

hussamkhatib avatar Nov 17 '23 19:11 hussamkhatib