cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Text beyond the X icon

Open Toledodev opened this issue 1 year ago • 14 comments

Found a bug? Please fill out the sections below. 👍

Issue Summary

The text on this input is overwriting the X icon space

Steps to Reproduce

  1. Edit some event-type
  2. Go to "Advance"
  3. Add a question and select "MultiSelect" type 4.Add more than two options

image

Loom video: https://www.loom.com/share/259ab60b675f497abb986d712e745fd9

Toledodev avatar May 18 '23 16:05 Toledodev

Hey @PeerRich @Jaibles, I already fixed the problem so I would like to open the PR for it 😄 image

Toledodev avatar May 18 '23 16:05 Toledodev

@Toledodev go for it!

PeerRich avatar May 18 '23 18:05 PeerRich

/bounty 20

PeerRich avatar May 18 '23 18:05 PeerRich

💎 $20 bounty created by PeerRich 🙋 If you start working on this, comment /attempt #8976 to notify everyone 👉 To claim this bounty, submit a pull request that includes the text /claim #8976 somewhere in its body 📝 Before proceeding, please make sure you can receive payouts in your country 💵 Payment arrives in your account 2-5 days after the bounty is rewarded 💯 You keep 100% of the bounty award 🙏 Thank you for contributing to calcom/cal.com!

Attempt Started Solution
🟡 @mukulbbhardwaj May 18, 2023 WIP
🟡 @adwait-godbole May 23, 2023 WIP
🟢 @AkhilG87 May 24, 2023 WIP
🟢 @VasuDevrani #9198

algora-pbc[bot] avatar May 18 '23 18:05 algora-pbc[bot]

/attempt #8976

mukulbbhardwaj avatar May 18 '23 19:05 mukulbbhardwaj

/attempt #8976

adwait-godbole avatar May 23 '23 12:05 adwait-godbole

Note: The user @mukulbbhardwaj is already attempting to complete issue #8976 and claim the bounty. If you attempt to complete the same issue, there is a chance that @mukulbbhardwaj will complete the issue first, and be awarded the bounty. We recommend discussing with @mukulbbhardwaj and potentially collaborating on the same solution versus creating an alternate solution.

algora-pbc[bot] avatar May 23 '23 12:05 algora-pbc[bot]

/attempt 8976

kshitiz-goel07 avatar May 23 '23 13:05 kshitiz-goel07

@PeerRich please give a review as this is my first contribution /attempt #8976

AkhilG87 avatar May 24 '23 10:05 AkhilG87

Note: The user @mukulbbhardwaj is already attempting to complete issue #8976 and claim the bounty. If you attempt to complete the same issue, there is a chance that @mukulbbhardwaj will complete the issue first, and be awarded the bounty. We recommend discussing with @mukulbbhardwaj and potentially collaborating on the same solution versus creating an alternate solution.

algora-pbc[bot] avatar May 24 '23 10:05 algora-pbc[bot]

@PeerRich please review pr #9103

AkhilG87 avatar May 24 '23 20:05 AkhilG87

I think instead of giving cross icon inside of input field ( It Feels like we want to clear input field value ) , We should give this icon next to input field ( That'll give a more better idea about that this icon will completely eliminate this input field ) @PeerRich

kshitiz-goel07 avatar May 25 '23 01:05 kshitiz-goel07

@mukulbbhardwaj: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏

algora-pbc[bot] avatar May 25 '23 19:05 algora-pbc[bot]

https://github.com/calcom/cal.com/pull/8981#issuecomment-1565959752 Please have a look. @PeerRich

VasuDevrani avatar May 29 '23 09:05 VasuDevrani

Fixed by https://github.com/calcom/cal.com/pull/9198

sean-brydon avatar May 30 '23 09:05 sean-brydon

💡 @VasuDevrani submitted a pull request that claims the bounty. You can visit your org dashboard to reward. 👉 @VasuDevrani: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

algora-pbc[bot] avatar May 30 '23 12:05 algora-pbc[bot]

🎉🎈 @VasuDevrani has been awarded $20! 🎈🎊

algora-pbc[bot] avatar May 30 '23 14:05 algora-pbc[bot]