Ryan Welcher

Results 100 comments of Ryan Welcher

Could this be related to the fixes in #167 ?

@psignoret absolutely. In our use-case, we have a separate AAD instance that allows us to log in as Vendors. To make this work, we had to unhook the built-in `authenticate`...

Perhaps we can filter the stored credentials instead?

I think the changes introduced with #167 address this issue.

Thanks @adamziel - I'll work on getting those updated!

With the current structure of the plugin, you would need to remove all of the `src` folders in each example along with the `vendor` and `node_modules` directory. There are also...

> Does it mean we won't run checks on commits to the main branch anymore? I'm open to discussing this for sure. My feeling is that if everything has to...

I've got the tests running locally but am intermittently running into timeout errors and the workflow is having issues as well. Open to any suggestions here.

> 🤔 I think it might be overkill to have e2e tests on example repo. The issue we have with the examples is we don't keep them in-sync with Gutenberg...

> I like a more progressive approach, so maybe we have some "complete blocks" that show all the pieces together including an e2e tests, but including them too early upfront...