Ryan Welcher
Ryan Welcher
Reviewed in the scrub today. There seems to be forward momentum.
> Do we know why the file is not pulled into the README? AFAIK docgen documents all public exports no? Doc gen only pulls in files that are referenced in...
@youknowriad I did that at first but thought we should keep all of the hooks together in the code base. I'm fine either way so if we're concerned about moving...
> For me, we shouldn't be adapting the code to the docs but If these things (hooks/intex.ts and entity-provider.js) are considered similar, it would make sense to group them in...
I think @Mamaduka suggestion probably makes the most sense here. Unless you have any concerns with that @youknowriad , I'll update the PR
Sounds good to me @youknowriad. To be clear, I was planning on moving the hooks in `entity-provider.js` into the `hooks` directory as their own files. Sorry I didn't make that...
This was reviewed during the Sept 15, 2020 bug scrub. We need someone to start work on this or it will most likely be punted to 7.0
Related #96
This is an interesting idea. Leave it with me.
Hi @pbearne! Can you explain further what you mean by "other loop"? Is that the main query or another instance of this block?