Ryan Welcher
Ryan Welcher
This PR introduces a lot of conditionals and it would be a really good idea to start abstracting out some of the functionality to make it easier to work with.
Based on a conversation with @gziolo in slack we think that changing the flag to `--no-plugin` makes more sense and is clearer in the context of running the full command...
I found an issue while testing where if a `--template` was passed that didn't support the `blockTemplatesPath` property an `assets` directory was created containing the actual template files. As a...
> https://github.com/WordPress/gutenberg/blob/9a4b95e37da8b4c4b271f510895690a4ea1fa780/packages/create-block/lib/prompts.js#L11 > > here we could make it more universal for the time being so it fits also the case when user passes `--no-plugin` flag: > > `The block...
related https://github.com/WordPress/gutenberg/issues/43235
This would also apply to block.json as well.
+1 from me on recommending using `printf` or `sprintf` instead of `echo` when possible.
@krisgale you can ( and should ) use `esc_html__`/`esc_html_e` with those functions. Can you provide an example? Perhaps I'm misunderstanding?
I see what you mean :) I think overall, this is a case of where the code is being used. If we have a template that is predominately HTML, I...
@krisgale @daveross - we should be careful about getting too close to a particular use-case/example for this. There are going to be lots of examples on both sides.