RabbitMqBundle icon indicating copy to clipboard operation
RabbitMqBundle copied to clipboard

Published 20 hours ago • verified publisher icon php-amqplib

Enable confirmation for producers (#660)

Open amigian74 opened this issue 3 years ago • 11 comments

Use confirmation acknowledgment for producer

amigian74 avatar Oct 05 '21 12:10 amigian74

could you squash commits into one for easier review?

Eloar avatar Oct 20 '21 11:10 Eloar

Can you please give this PR a proper title?

ruudk avatar Nov 30 '21 12:11 ruudk

Happy new year. What is missing here?

amigian74 avatar Jan 03 '22 07:01 amigian74

@amigian74 as far as I can tell there was requested change to ProducerInterface (to not to declare return type with type hint as it is breaking change). I was suggesting adding description to doc comment of added method.

Eloar avatar Jan 03 '22 07:01 Eloar

Hi. In my opinion all requests should by fullfilled by now

amigian74 avatar Jan 11 '22 12:01 amigian74

How ist this possible? I only added a doc comment to the new function.

amigian74 avatar Jan 28 '22 13:01 amigian74

Can anybody please help me with this - this feature is really important for us

amigian74 avatar Mar 17 '22 09:03 amigian74

@amigian74 as I said in my previous comments, this contains breaking changes also it seems that you started from another branch or smth as if you will look in the diff, you will see changes that aren't yours (as you said).

This PR is not mature enough, please consider cleaning you code to contain only your modifications and to not create possible breaking changes.

I really appreciate you help and I understand that you need this feature, however it needs to be clean in order to merge it.

mihaileu avatar Mar 17 '22 16:03 mihaileu

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 19 '22 08:06 github-actions[bot]

Is there still something to do here?

amigian74 avatar Jun 23 '22 05:06 amigian74

Hi, are you planning a new release soon with this request in it? It's really important for me,

amigian74 avatar Aug 30 '22 09:08 amigian74

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 28 '22 12:11 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Dec 12 '22 16:12 github-actions[bot]