Ruud Kamphuis comments

Results 363 comments of


                                            Ruud Kamphuis

Replace static variables and statically referenced types with instance based TypeRegistry

@spawnia if you have time I'd like to hear your thoughts on this. 😊

Replace static variables and statically referenced types with instance based TypeRegistry

@shmax I first want to know if this is a direction to be considered. Then I'd be happy to spend time on it and come up with a PR.

Replace static variables and statically referenced types with instance based TypeRegistry

@shmax @spawnia Created a PR to resolve this issue: https://github.com/webonyx/graphql-php/pull/1426

Do not add a `ReflectionClassResource` to the container when class is annotated with `#[Excluded]`

@nicolas-grekas I'd like to give it a try. I just wonder what the best approach will be. The ReflectionClassResource is automatically added when something calls `ContainerBuilder::getReflectionClass`. https://github.com/symfony/symfony/blob/95fa158937318680e2ccca09539efca9a4405b48/src/Symfony/Component/DependencyInjection/ContainerBuilder.php#L344-L385 This method is...

Unused variable should not be trigger if the child mutate a parent's variable.

Noticed the same, here a code sample that does it: ```twig {% extends 'base.html.twig' %} {% set layoutTitle = 'Home' %} {% block main %} Test {% endblock %} ```...

Conditional return via static lookup array

Thanks, that already looks better. Couldn't we use `object` for this? Like: `@return (K is key-of ? object : null)`

Conditional return via static lookup array

It's getting better but still not working properly: https://phpstan.org/r/e9ae422d-ab7f-400e-99df-f213c1022b09

Conditional return via static lookup array

Thanks! @ondrejmirtes is this something you would accept as a PR? @rvanvelzen would you want to submit this as a PR? If you don't want to I can do it...

Conditional return via static lookup array

The issue is that T is class-string, not an object of T. Introducing object would allow to type that. https://github.com/phpstan/phpstan/issues/9704#issuecomment-1660369960

Conditional return via static lookup array

That's even better!