opentitan
opentitan copied to clipboard
Out_iso_vseq
[usbdev] out_iso_sequence
Adds usbdev_out_iso_sequence
@rswarbrick @alees24 please review this PR.
I believe that this PR was just supposed to be for one of the vseqs. Please could you force-push to drop the other commits?
Okay, I have removed spare commit. Please review it.
I've just force-pushed to the PR to resolve some rebasing conflicts. No other change.
Thanks for this: the code looks really good. I've just re-read the testplan item, which ends with "Verify that the device does not send any handshake packet in response."
I guess we're not exactly checking that no handshake packet came out? If that's right, I think it's reasonable! Would it also make sense to wait a little bit (100 USB cycles or something) and then check that usbdev hasn't sent a handshake packet while we were waiting?
Thanks for this: the code looks really good. I've just re-read the testplan item, which ends with "Verify that the device does not send any handshake packet in response."
I guess we're not exactly checking that no handshake packet came out? If that's right, I think it's reasonable! Would it also make sense to wait a little bit (100 USB cycles or something) and then check that usbdev hasn't sent a handshake packet while we were waiting?
Now i have coded to verify that device does not send any handshake packet after receiving OUT ISO trans until timeout condition of usb device. can you please review this. Thanks
Thanks for this PR. Superseded now that USBDEV has reached V2S status.