ronso0
ronso0
> > Shall we also change the cue color when changing the type? > > Good question. I would suggest we don't, but I guess we could change it if...
Can we remove the obsolete cue end position after switching from loop -> hotcue _when closing the menu_? It just feel weird to be left with hotcues that have an...
> Can you double check that the loopsize still doesn't change when toggling the type and the loop is not aligned to a beat. For example when a user sets...
> This would require to implement an history of cue modification and I'm not going to do this here. If this a deal breaker, happy to close the PR. I...
@daschuer wanna take a look?
> Can we remove the obsolete cue end position after switching from loop -> hotcue _when closing the menu_? > > It just feel weird to be left with hotcues...
Ouh sorry, thanks for the reminder. LGTM, thank you very much!
gonna take a in-detail look soonish. think this could slip in during beta IMOH (regression fix etc.)
Well, it works as desired now, thanks! I also have a hard time double-checking all callers, and I didn't spent time on an alternative fix. Changes LGTM from what I...
I changed the base branch to 2.5, now that 2.6 has been split off.