ronso0
ronso0
Haven't tested it either, yet, will do so next week.
IIUC we now need to query the keyboard config via KeyboardEventFilter in order to show the correct shortcut in the sidebar context menu. I.e. show either F2 (keyboard disabled) or...
Just FYI #13082 hasn't been reviewed, yet, so it's unclear if it'll be merged as it is now and when that'll happen of course. I.e. I don't recommend to make...
I think, with current main, we need to pass a CoreServices (or KeyboardEventFilter) pointer to the library features that need to access the keyboard cfg, and maybe update the sidebar...
Thank you, that sounds reasonable.
> I am building Mixxx on my Linux machine inside a VS Code DevContainer, and its sloooooooooow as soon as multiple files are affected. Do you maybe have any tips...
> I think the most clean way is to "register" the actions that have to be updated with the `KeyboardEventFilter` Yup, like it's done for the menu bar actions in...
I'll try this soonish. Regardless when this will be merged, you can run a personal branch with all PRs merged that you need.
> I'm still figuring out how this project "ticks", and which way of contributing (small, frequent PRs vs. longer, larger ones) works best. Yeah, there's no general receipt, developer time...
Yes, IMO this is ready for merge. The only aspect I feel a little uncomfortable with is that we now have two different edit hotkeys: * F2: applies if shortcuts...