Robert Nagy
Robert Nagy
@mcollina any ideas?
Is this some internal node requirement when loading commonjs modules? Off thread module loading maybe?
@metcoder95 @mcollina I have some http2 and mock test failures I haven't been able to figure out. Would appreciate some help.
> Shall we update the docs to state the change? Where how? I tried updating docs. Did I miss something?
I think I managed to fix the failures
Also I think my list is missing the GitHub release
This still looks weird... where/how does the origin get lost?
``` diff --git a/lib/interceptor/dns.js b/lib/interceptor/dns.js index c8d56c2c..c6a1a480 100644 --- a/lib/interceptor/dns.js +++ b/lib/interceptor/dns.js @@ -342,6 +342,10 @@ module.exports = interceptorOpts => { return dispatch => { return function dnsInterceptor (origDispatchOpts, handler)...
> If that is the case, then I think there are a lot of inconsistencies and contradictions in both the code and documentation. Possibly. Then let's just make the dns...
> I think that Client and Pool actually should throw an error when origin is provided to request(), so that the caller notices that it is wrong. It should throw...