Robert Nagy comments

Results 385 comments of


Robert Nagy

Filter tls options

> Since we are passing those opts to the core tls library, all of them? I fear I'm missing something 🤔 We don't support all of them: https://nodejs.org/api/tls.html#tls_new_tls_tlssocket_socket_options. Some of...

fetch() performance parity

Do you have a reproducible benchmark we can use?

fetch() performance parity

@benjamingr why is creating abort signals so expensive?

fetch() performance parity

@jasnell @addaleax

Can't bring custom `abort-controller` implementation to undici.fetch

@KhafraDev

Error handling?

PR is welcome

fix: readable.setEncoding

@koh110 Would you mind fixing tests?

fix: readable.setEncoding

Fixing this is very complicated unfortunately... :/

Can't remove default headers. Can't overwrite `"sec-fetch-mode"`, `"connection"` headers.

Can you check what Chrome does? I think most of the behavior you are seeing is regulated by the spec.

Can't remove default headers. Can't overwrite `"sec-fetch-mode"`, `"connection"` headers.

> **2** and **3** are obviously bugs. > For **1**, for me: > - Either add a way to remove the default headers, ~for example, by setting its value to...