undici icon indicating copy to clipboard operation
undici copied to clipboard

fix: readable.setEncoding

Open ronag opened this issue 2 years ago • 5 comments

Fixes: https://github.com/nodejs/undici/issues/1125#issuecomment-987724800

ronag avatar Dec 07 '21 14:12 ronag

@koh110 Would you mind fixing tests?

ronag avatar Dec 07 '21 14:12 ronag

Codecov Report

Merging #1129 (a0a0f72) into main (ebea0f7) will increase coverage by 2.14%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   94.25%   96.40%   +2.14%     
==========================================
  Files          40       30      -10     
  Lines        3815     2501    -1314     
==========================================
- Hits         3596     2411    -1185     
+ Misses        219       90     -129     
Impacted Files Coverage Δ
lib/api/readable.js 79.31% <83.33%> (-9.49%) :arrow_down:
index.js 85.13% <0.00%> (-14.87%) :arrow_down:
lib/core/util.js 89.14% <0.00%> (-9.31%) :arrow_down:
lib/handler/redirect.js 87.34% <0.00%> (-7.60%) :arrow_down:
lib/core/errors.js 91.39% <0.00%> (-3.23%) :arrow_down:
lib/fetch/formdata.js
lib/fetch/constants.js
lib/fetch/body.js
lib/fetch/util.js
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebea0f7...a0a0f72. Read the comment docs.

codecov-commenter avatar Dec 07 '21 14:12 codecov-commenter

@ronag Thanks for your PR. Here is my test code. Would you review it? https://github.com/nodejs/undici/pull/1131

koh110 avatar Dec 07 '21 15:12 koh110

Fixing this is very complicated unfortunately... :/

ronag avatar Dec 07 '21 16:12 ronag

@ronag @mcollina Hi. I tried to fix this bug. But I'm not sure if I've fixed it perfectly. Would you review it? https://github.com/nodejs/undici/pull/1133

koh110 avatar Dec 08 '21 15:12 koh110