Robert Nagy

Results 385 comments of Robert Nagy

> I am wondering if people expect the same defaults as on the browser side? The `undici.request` API does not work on the browser side.

This can be done in a combination of two ways: - Try to cause errors in chrome console and see what it prints - Read the chrome source at https://github.com/chromium/chromium/tree/94.0.4604.1/third_party/blink/renderer/core/fetch

@KhafraDev which one of the above do we need to check off?

> which I think is an HTTP spec violation Do you have a reference? > I believe browsers will correctly honor cache-control: no-transform (& when accept-encoding: gzip is sent in...

> Browsers handle it because they use an internal cache that does qualify as a transforming proxy So do browsers still apply it if `no-cache` is specified? i.e. `cache-control: no-cache...

> 1. `pending` -> `queued` (in order to avoid confusing w/ `running`) Fixed: > 2. Does the `failed` event have an error argument? Yes. Alternatively we could combine complete/failed and...

> NR (and all others) will need a way to inject custom headers for each request. That should be reasonably simple already. Just extend `Agent` and pass another handler wrapping...

@delvedor Would you mind looking at this? I would like to move the tls options out on root instead of making it possible to pass anything in an nested options...

> what problems do you foresee here? It's a bit unclear what option exactly we support or not.