Robert Nagy

Results 385 comments of Robert Nagy

> I'd like to confirm what we think about `cors` related features, for example, `mode` is currently supported, while it's unimplemented in node-fetch. Do we want to support them as...

The `AbortError` seems like a bug. Should probably be another error. So this issue is actually 2 different problems.

@mcollina wdyt? node-fetch has support for this https://github.com/node-fetch/node-fetch/blob/8b54ab4509b541dadcd2d66aa5cf0995ad54ac15/src/index.js#L258-L270

Maybe would be better to target @jasnell's node http3/quic branch? I'm not too comfortable with node core http2. https://github.com/nodejs/node/pull/38233

> @ronag what's the issue with the core node HTTP/2? https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3Ahttp2

I guess it could.

But if it's only 64k I think we could just have it as a default. It's more relevant if we have something like > 128k.

https://github.com/node-fetch/node-fetch/issues/151 https://github.com/node-fetch/node-fetch/issues/248

We need a "max" highWaterMark then.