Robert Nagy

Results 385 comments of Robert Nagy

@delvedor Thanks! Maybe we could dynamically check for those and set idempotent accordingly?

Also I would recommend using different undici dispatchers for pipelinable and non-pipelinable requests.

I'm mostly familiar with couchdb and in our couch client we use one dispatcher per couch view.

Cool! What about the keep-alive hint?

> Elasticsearch has no timeout or pipelining limit and sends no hints :) Then you might want to set `keepAliveTimeout: 5 * 60e3` or something so that undici doesn't aggressively...

Another thing (since I'm on this topic). It is **very** important that the client fully consumes any and all response bodies. Might be worth to add to documentation if end-users...

@mcollina wdyt?

> If I understand correctly your point about Async Context, I think we could implement in a non-standard way is an API such as: That's exactly what I was thinking!...

> My only worry is if this would be useful to our Node.js users. Why would somebody need that? Heh, good question. Let me give it some more thought.

I'm a bit on the fence as well. Would be good with some feedback.