Robert Nagy

icon indicating a website link https://www.npmjs.com/~ronag icon indicating an email [email protected]

icon company @nxtedition icon location Malmö icon location Co-Founder @nxtedition Maintainer @CasparCG Collaborator & TSC Member @nodejs

Results 379 comments of Robert Nagy

undici.fetch does not append url fragments (url.hash)

PR welcome

undici.fetch does not append url fragments (url.hash)

I think we have the same problem in all undici api's

undici.fetch does not append url fragments (url.hash)

> I thought that the fragment should not be sent to the remote server? I actually don't know. Anyone know what the spec says? What does Chrome do?

undici.fetch does not append url fragments (url.hash)

What does Chrome do?

client.request throws Error with setEncoding

> I think that this code needs to use consume.stream._readableState.decoder.end() in consumeEnd instead of Buffer.concat(body) if the value is in readableEncoding. Is this the right way to fix it? Just...

client.request throws Error with setEncoding

I think that would work.

client.request throws Error with setEncoding

I you open a PR with the tests then we can collaborate on it.

feat: onRedirect

@szmarczak started a bit in case you want to have a try a it. I think it's mostly the test missing.

spec doesn't finalize connection on network error

@szmarczak @annevk

spec doesn't finalize connection on network error

https://github.com/nodejs/undici/commit/42b67e12b3b62a47789b7bf6ea4a64be8d8a9f25