undici icon indicating copy to clipboard operation
undici copied to clipboard

Throw On Error by default?

Open ronag opened this issue 1 year ago • 4 comments

Should we enable throwOnError by default on the request method? Semver major.

ronag avatar Jul 14 '22 14:07 ronag

I'm not entirely convinced. Creating errors is somewhat expensive, and I prefer to handle things manually. However, most people might feel different.

mcollina avatar Jul 14 '22 14:07 mcollina

I'm a bit on the fence as well. Would be good with some feedback.

ronag avatar Jul 14 '22 14:07 ronag

I am wondering if people expect the same defaults as on the browser side?

weyert avatar Jul 15 '22 18:07 weyert

I am wondering if people expect the same defaults as on the browser side?

The undici.request API does not work on the browser side.

ronag avatar Jul 15 '22 18:07 ronag