bob icon indicating copy to clipboard operation
bob copied to clipboard

Construct flow

Open Fishrock123 opened this issue 4 years ago • 1 comments

Some kind of construct flow would be very useful for a couple of significant reasons:

  • Presently resources must either be opened upon constructor call, or upon "first pull".
    • The former presents async timing issues
    • The latter is complicated and messy
  • It would be useful to pass buffer allocation hits out-of-flow (https://github.com/Fishrock123/bob/issues/52)

Arguments for doing it all inline could be getting pretty long (and very variable), not even counting the first point:

pull(status_type, error, buffer, size, offset)

Maybe?

Idk, maybe separating this all out into multiple flows would be better, similar to Streams3 but just sans the dreaded EventEmitter.

  • (sink calls) -> (source calls)
  • construct(...) -> ready(...)
  • pull(...) -> give(...)
  • destroy(error) -> destroy(error)

Very related to https://github.com/nodejs/node/issues/29314

Fishrock123 avatar Sep 23 '19 19:09 Fishrock123

I'll chime in a link to related PR in Node https://github.com/nodejs/node/pull/29656.

ronag avatar Oct 06 '19 09:10 ronag