Robert Nagy

icon indicating a website link https://www.npmjs.com/~ronag icon indicating an email [email protected]

icon company @nxtedition icon location Malmö icon location Co-Founder @nxtedition Maintainer @CasparCG Collaborator & TSC Member @nodejs

Results 379 comments of Robert Nagy

response is only finished if socket is detached

Updated test

response is only finished if socket is detached

Fails in node < 0.4. Is that a problem?

response is only finished if socket is detached

Is there anything more I can do here?

response is only finished if socket is detached

The coveralls and node < 4 are a bit out of my expertise.

response is only finished if socket is detached

> you can help me understand the changes in this PR and/or how you've been manually testing the changes, which I can help replicate into automated tests. So the problem...

response is only finished if socket is detached

Another way to phrase it. This PR fixes so that ‘isFinished’ is never true before ‘onFinished’ has been called.

response is only finished if socket is detached

> So I had originally saw your multiple commit iterations, and there is the http/2 issue. Were you testing the changes by hand? If so, can you help me replicate...

response is only finished if socket is detached

This is also relevant https://github.com/nodejs/node/pull/28621

response is only finished if socket is detached

https://github.com/nodejs/node/pull/28681

Publishing @nodejs/i18n under `@nodejs` scope on npm

> We are reserving the nodejs scope for internal /core usage. I'm -1 for using it for external usage. What's the definition of internal vs external? Whether or not it...