Rob Shakir

For safety, `pyangbind` treats warnings from `pyang` as errors. The only two error types that are permitted are around invalid regexp patterns, and unused imports. You can edit this [here](https://github.com/robshakir/pyangbind/blob/master/pyangbind/plugin/pybind.py#L307)...

Yes, this looks like an error -- I'm happy to review a PR to cover this, or I can make a change (although it might take a short while).

The `delay` leaf consistently means that we should delay after the trigger having occurred -- so it shouldn't ever be interpreted as a timeout. It's fine for an implementation not...

Hi, With the current specified set of one _could_ move the `prefix-limit` configuration to being within the root (AFI, SAFI) container. The motivation and benefit that the current structure has...

An example where `all-afi-safi-common` may not be used is Route Target constrain [RFC4684](http://tools.ietf.org/html/rfc4684). In this case, the peer is announcing the set of RTs that they are interested in to...

I did miss it -- apologies, let me review ASAP.

@JonasKs holy-moly! apologies! this one passed me by. reviewing now. 🔎

Please re-open if you have additional data. It's not clear that this refers to the collector in this repository.

This is still inconsistent with how next-hop-self is represented in OpenConfig -- where it is something that is within a policy not a leaf. I don't agree with this proposal...

Next-hop self is specified through: 1. (`/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/config/set-next-hop`)[https://openconfig.net/projects/models/schemadocs/yangdoc/openconfig-routing-policy.html#routing-policy-policy-definitions-policy-definition-statements-statement-actions-bgp-actions-config-set-next-hop] 2. (`bgp-next-hop-type`)[https://openconfig.net/projects/models/schemadocs/yangdoc/openconfig-routing-policy.html#type-bgp-next-hop-type] enum values -- i.e., `SELF` here. We have discussed this numerous times over the years -- since some implementations have this...