Rob Shakir comments

Results 387 comments of


                                            Rob Shakir

`EncodeTypedValue` and `findUpdatedLeaves` don't support keyless/unkeyed lists

We should mark these lists as atomic in the schema, such that all leaves under them are already expected to be sent together. Then, to serialise them the solution space...

Union field has nil value after xml.Unmarshal

ygot doesn't support XML marshalling and unmarshalling, solely RFC7951 JSON. If you would like to add support for this, we would welcome a contribution.

Bump github.com/openconfig/gnmi from 0.10.0 to 0.11.0

@dependabot recreate

Bump golang.org/x/net from 0.17.0 to 0.23.0

@dependabot rebase

gnmi-1.15 gnmi_set_test.go

OpenConfig project historian perspective only. As a YANG practicality: we have lists of interfaces that require a base interface name, but optionally require a subinterface -- in such lists, we...

Clarification regarding changes proposed for handling election ID

Hi @VijayKestur, The reason that we made this change is that there is no guarantee that the election ID changes when there is a new ID provided, consider the case...

Add IPv4 entries that are resolved by NHG and NH, in random order

The compliance test here can be skipped for cases where random ordering is not required using the `RequiresServerReordering` flag. Not all use cases will require this (per the discussion of...

ytypes.Unmarshal() treating 50 as a float64 even though I am converting 50 to string before unmarshalling

Hi, Could you provide the JSON input you're using? This sounds like you might have this field set as `foo: 50` rather than `foo: "50"`. Thanks, r.

ytypes.Unmarshal() treating 50 as a float64 even though I am converting 50 to string before unmarshalling

Can you provide both the JSON and the YANG module? It's important how the leaf is defined to be able to debug this.

Remove duplicate word in gNMI spec docs

Thanks for the fix -- please could you sign the CLA such that we can review and accept this contribution.