Rob Shakir

Results 387 comments of Rob Shakir

couple of comments on this issue: * (nit, but important) the RPC is `Set`, so we should think about this as a "successful `Set`" not a successful `SetRequest`. * you...

I find the use of `SetRequest` and `SetResponse` in this context confusing :-) `Set` is an RPC that takes a payload of `SetRequest`, the response to the RPC is a...

Based on the comments here, @dplore - I suggest we write a short document that describes the constraints on the design space, the existing guidance, and the potential solutions and...

According to RFC6020, this shouldn't be an issue. Imported modules are scoped according to the module or submodule that they are imported in, therefore it should not be the case...

gNMI does not place a restriction here -- we just require that the path element is defined in terms of a uniquely identifying value that consists of the tuple of...

Thanks for this -- you can create a PR by forking the repo and pushing there. We can review the code then (generally, this looks to improve portability, but I'd...

Thanks for this -- let me look again this week. Unfortunately, I was on an extended leave during the period you previously requested review.

@marcushines - PTAL too.

Today, ygot only supports `anydata` when transpiling to protobuf rather than Go. We map to `google.protobuf.any` in the proto case -- we didn't add something similar in Go, since there...