Rob Shakir comments

Results 387 comments of


                                            Rob Shakir

gNMI.Set - Config Diff Extension

Let's keep this PR/issue focused on the core topic. We deliberately did not expose these semantics (long-lived candidates, rollback across different transactions) in gNMI. They raise many corner cases that...

gNMI.Set - Config Diff Extension

gNMI extensions provide more than this capability, so no, we will not deprecate gNMI extensions based on any decision in this issue.

Get Response in case of multikey path should be sorted at server side or client ?

This should be implemented at the server side for both `Subscribe` and `Get` in my view.

RT-14.2: gRIBI route test changes incorporated.

@rohit-rp -- please check this PR based on a deviation being added to skip a test.

RT-14.2: gRIBI route test changes incorporated.

@rohit-rp -- please check this PR based on a deviation being added to skip a test.

juniper_gnmi.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

Please re-open if this is relevant to this repo, or needs specification clarifications.

protoc-gen-go-grpc gRPC code generation plugin downgraded

Aaron -- thanks for flagging this. This looks like an error. Let me chase it up.

Add SVI example documentation

Thanks for the contribution here, and apologies for the review delay :-( I'm reviewing this and will discuss it tomorrow with the wider group.

SubscribeResponse.GetUpdate().Updates length varies in large telemetry updates

hi! if you're just calling `&gpb.SubscribeResponse{}.GetUpdates().Updates` then this is code that is in the generated `.pb.go` file, and should not have any constraint on the length that I am aware...

Add policy forwarding for next hop match and GUE encapsulation action

Can we link another implementation here?