Rob Shakir
Rob Shakir
Sure, that's fine with me. I don't think this materially changes anything. I still think that we should cut 1.0.0 of the `openconfig-platform` model though. I can do this in...
@dplore - done. Can we establish an expected merge date for this PR please?
This is replaced by #754.
@nokia1adam @earies - it looks like Juniper doesn't allow specifying a specific instance ID integer; Cisco doesn't seem to have such a field; Nokia does support specifically specifying the `instance-id`...
Thanks @aaronmillisor! The `instance-id` statement is what I was missing here. This matches the configuration of the uint ID that Nokia SROS has.
That's my proposed solution, yes. We'd remove this leaf, and add a new `instance-id` leaf that matches the encoding in the protocol.
@earies -- would you like to make the proposed changes above? If not, I'm happy to open a PR for this.
Doing this behind a flag would solve the backwards incompatibility issues at least initially. Some care needs to be taken with what the naming of the `oneof` is -- but...
@dependabot rebase
Yes, we do not allow partial update of leaf-lists in gNMI -- we declaratively require them to be entirely specified.