gribi
gribi copied to clipboard
Add IPv4 entries that are resolved by NHG and NH, in random order
In the HLD document in section TE-3 (Support for Hierarchical Lookups) it is mentioned that the NHGs and NHs will be sent in a single ModifyRequest. The test case and the requirement in the HLD seems to be contradictory. Can you please clarify?
Can you add a link to the source which is in question?
Is this the portion of the code where you see the randomization? https://github.com/openconfig/gribigo/blob/main/compliance/compliance.go#L561
@xw-g the specific issue is whether or not these entries should be random or in-order. Currently https://github.com/openconfig/gribigo/blob/484488bcca14e705ddc045050239167054200dff/compliance/compliance.go#L561 is set to random and our requirements say in order. Should we change this?
The compliance test here can be skipped for cases where random ordering is not required using the RequiresServerReordering
flag. Not all use cases will require this (per the discussion of the "HLD" here). gRIBIgo supports this, so the compliance test can be passed by some implementations.