gribi icon indicating copy to clipboard operation
gribi copied to clipboard

Add IPv4 entries that are resolved by NHG and NH, in random order

Open shireeshbhat opened this issue 2 years ago • 3 comments

In the HLD document in section TE-3 (Support for Hierarchical Lookups) it is mentioned that the NHGs and NHs will be sent in a single ModifyRequest. The test case and the requirement in the HLD seems to be contradictory. Can you please clarify?

shireeshbhat avatar Sep 15 '22 06:09 shireeshbhat

Can you add a link to the source which is in question?

dplore avatar Sep 15 '22 21:09 dplore

Is this the portion of the code where you see the randomization? https://github.com/openconfig/gribigo/blob/main/compliance/compliance.go#L561

dplore avatar Sep 15 '22 21:09 dplore

@xw-g the specific issue is whether or not these entries should be random or in-order. Currently https://github.com/openconfig/gribigo/blob/484488bcca14e705ddc045050239167054200dff/compliance/compliance.go#L561 is set to random and our requirements say in order. Should we change this?

dplore avatar Sep 15 '22 21:09 dplore

The compliance test here can be skipped for cases where random ordering is not required using the RequiresServerReordering flag. Not all use cases will require this (per the discussion of the "HLD" here). gRIBIgo supports this, so the compliance test can be passed by some implementations.

robshakir avatar Oct 17 '24 09:10 robshakir