Robert Osfield

I'm not a Windows/MFC dev so could you please provide some background to what is done in this PR, with links to resources that would help inform of what is...

Thanks for the info. To get the ball rolling I have merged the PR as a branch: https://github.com/vsg-dev/VulkanSceneGraph/tree/640kb-master I will need to learn about the topic and see if I...

I have finally had a chance to look at this PR. I am still somewhat rooting around the dark, but learning as I go... First up I've merged this PR...

@640kb I'm looking at the Windows docs in CallWindowProc: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-callwindowproca And it mentions handling STRICT and non STRICT types differently. Do we need to declare Win32_Window.cpp windowProcedure using their suggestion?...

@640kb I have created a windowProcedure branch with just added the Win32_Window::windowProcedure function pointer rather than the WindowTraits mechanism for doing this. If this works then I'd prefer it as...

I'm just reviewing the suggested placement of LRESULT CALLBACK Win32WindowProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) into the Win32_Window.h. I'm not the author of Win32_Window or have expertise under...

Looking at the Win32WindowProc implementation: ~~~ cpp // our windows events callback LRESULT CALLBACK Win32WindowProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { Win32_Window* win = reinterpret_cast(GetWindowLongPtr(hwnd, GWLP_USERDATA)); if (win...

OK, here's my proposal of moving responibility for calling DefWindowProc out of the handleWin32Messages method: https://github.com/vsg-dev/VulkanSceneGraph/tree/Win32WindowProc I have also added what I think is missing VSG_DCLSPEC export. For uses adapting...

Thanks for the example. Does this mean the [Win32WindowProc](https://github.com/vsg-dev/VulkanSceneGraph/tree/Win32WindowProc) branch works fine and should be merged with VSG master?

Just merged vsgwin32 with vsgExamples and tested it under Windows 11 and it works fine with the Win32WindowProc branch so I'll merge it with VSG master.