Ryan Ly comments

Results 455 comments of


                                            Ryan Ly

Make ImagingPlane.description optional

Looks good. Thank you @stephprince ! Could you please approve?

Make `NWBFile` groups optional :)

I agree with @bendichter . Having empty groups is confusing and inelegant, particularly when browsing `NWBFile` in an HDF5 viewer or neurosift. `/stimulus/presentation` gets me every time because `stimulus` is...

[Feature]: Allow passing DynamicTable for ElectricalSeries.electrodes and RoiResponseSeries.rois

This change would be accompanied by a change in our docs that moves explanation of the `DynamicTableRegion` into a note box. This would indicate that using a `DynamicTableRegion` is more...

[Feature]: Allow passing DynamicTable for ElectricalSeries.electrodes and RoiResponseSeries.rois

I like @bendichter 's latest suggestion. While we are rethinking this, what do you think about using the term "selection" or "rows" instead of "region"? "Region" to me suggests a...

Fix pandas FutureWarning: Avoid chained assignment with copy() in icephys.py

@copilot This fix may ultimately require a PR in the HDMF repository instead of PyNWB.

Fix pandas FutureWarning: Avoid chained assignment with copy() in icephys.py

@copilot please review and address the failing tests

[Feature]: Importing pynwb creates redundant type maps

Also should investigate whether deepcopying the global typemap in `get_type_map` is necessary.

[Feature]: Clean up HDMFIO.load_namespaces call

This depends on changes in hdmf and hdmf-zarr linked above to be merged first

deprecate Python 3.9

Thanks for this PR @bendichter ! It looks all good to me. This should be in a minor release. We should also explore adding Python 3.14 support in a separate...

deprecate Python 3.9

We'll make a bugfix release imminently and then do a minor release with this PR deprecating python 3.9 shortly after