Ryan Ly
Ryan Ly
Unfortunately, that is another oversight. ```python import pynwb from pprint import pprint pprint(pynwb.get_type_map().namespace_catalog.get_namespace("core").get_spec("CurrentClampSeries").get_dataset("data")) ``` returns ``` {'attributes': [{'doc': 'Base unit of measurement for working with the data. ' "which is...
The schema language docs needs to be corrected to our new understanding of the default behavior for shape. Our intention that is consistent with the schema and how HDMF works...
> I was looking at this line and assumed it would inherit the data specifications [NeurodataWithoutBorders/pynwb@`f956fbb`/src/pynwb/icephys.py#L187](https://github.com/NeurodataWithoutBorders/pynwb/blob/f956fbb30fdf361a9ae43a71fa509218012adb46/src/pynwb/icephys.py#L187) Correct. PyNWB makes `CurrentClampSeries.data` inherit from `PatchClampSeries.data` including any dtype and shape validation. These...
Sorry for the confusion. I think `CurrentClampSeries.data` as written should automatically inherit the numeric dtype, 1D shape, required-ness, and other properties from `PatchClampSeries.data` because it does not explicitly override them....
In discussion with @oruebel: Yes, child types that override a dataset or attribute of the parent type should inherit the dtype, shape, and other properties from the corresponding dataset or...
You can track progress on the HDMF issue here: https://github.com/hdmf-dev/hdmf/issues/320 MatNWB should also follow the inheritance logic described above.
> 1. `PatchClampSeries.data` overrides some specification keys from the `TimeSeries.data`, i.e `dtype`, `dims` and `shape`. This is explicitly stated in the `PatchClampSeries.data` specification. Correct. `PatchClampSeries.data` inherits all specification keys that...
According to the spec / spec language, the link name is optional. You can have an unnamed link to a data type, and objects should be mapped as a link...
Waiting on https://github.com/NeurodataWithoutBorders/pynwb/pull/2111 to be all green before approving and merging into `dev`.
TODO: Update BehavioralEpochs docstring