spyglass icon indicating copy to clipboard operation
spyglass copied to clipboard

Uniqueness of object_ids in generated analysis nwb files

Open samuelbray32 opened this issue 9 months ago • 3 comments

Is your feature request related to a problem? Please describe.

  • In the current implementation of AnalysisNwbfile.create() the new nwb inherits the object id of both the nwb file and objects within it that aren't removed.
  • This causes errors when attempting to make a dandiset since uniqueness is violated. Relevant to (3) in #861
  • The UUID of the object id is not a hash of the data, so in theory I think it would be ok to alter them to be unique.

Describe the solution you'd like A retroactive solution needs to:

  • alter the object_ids of existing files
  • correct the stored datajoint checksum/hash
  • correct any spyglass utilities that use this to find data

A forward solution needs to:

  • ensure unique object ids are created when creating a new analysis file

Describe alternatives you've considered Would need dandi to change restriction policy on overlapping uuid. Since the same uuid do redundantly refer to duplicated data in different nwb files this might not be unreasonable.

samuelbray32 avatar May 03 '24 21:05 samuelbray32