Riley Karson

Results 109 comments of Riley Karson

These test failures are unrelated to your change it turns out, and are failing in nightlies when we always call live APIs. https://github.com/hashicorp/terraform-provider-google/issues/17531 and a bug to-be-filed for the IAP...

(If I haven't gotten back to this in a couple days after that fix, ping me by commenting here)

https://github.com/GoogleCloudPlatform/magic-modules/pull/10476 is merged. I don't think there's any conflicts so no need to rebase or anything, or CI does that if it can (and fails if it can't due to...

override-breaking-change: `Optional` + `Computed` is a superset of the previous DiffSuppressFunc.

Google-internal details captured in b/335469333, @vickramp will follow up here when we should merge.

@dvfons: I'm seeing a CLA issue on your new commit, can you resolve that? Thanks!

``` Error: Error creating RegionInstanceGroupManager: googleapi: Error 400: Invalid value for field 'resource.instanceFlexibilityPolicy': ''. Setting instance flexibility policy is not allowed., invalid ```

Adding @ScottSuarez as a mandatory reviewer- we should ensure that MTLS is not broken as a result of this change.

Running tests to make sure there are no surprises, but lgtm assuming there's none