Add support for instance_ip_mode to appengine flexible in beta

[gwendal-lecren]

Add support for instance_ip_mode in google_app_engine_flexible_app_version resource in the beta provider. Not sure it is the right place to open a PR, but trying to address this issue: https://github.com/hashicorp/terraform-provider-google/issues/17510

---

Release note

appengine: added field `instance_ip_mode` to resource `google_app_engine_flexible_app_version` resource (beta)

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[gwendal-lecren]

/gcbrun

[rileykarson]

/gcbrun

[gwendal-lecren]

Hello @rileykarson - Does it look good to you or do you have any other feedback I should address? Thanks! :)

[rileykarson]

/gcbrun

[gwendal-lecren]

Hello @rileykarson, hope you're doing well - Is there anything missing or does it look good on your side? Thanks! :)

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+)) google-beta provider: Diff ( 5 files changed, 33 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 7 files changed, 25 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3569 Passed tests: 3175 Skipped tests: 368 Affected tests: 26

Click here to see the affected service packages

all service packages are affected

Action taken

Found 26 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample|TestAccAppEngineDomainMapping_update|TestAccAppEngineFirewallRule_appEngineFirewallRuleBasicExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccAppEngineStandardAppVersion_update|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccSqlUser_postgresIAM

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccAppEngineFirewallRule_appEngineFirewallRuleBasicExample[Debug log] TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Debug log] TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Debug log] TestAccAppEngineStandardAppVersion_update[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample[Debug log] TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log] TestAccIapAppEngineServiceIamBindingGenerated[Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Debug log] TestAccIapAppEngineServiceIamMemberGenerated[Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Debug log] TestAccIapAppEngineServiceIamPolicyGenerated[Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_update[Error message] [Debug log] TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[gwendal-lecren]

Hello @rileykarson - Getting back to you regarding the tests, it seems some of them ran into issues but I don't have access to the logs (getting a 403). Would you have some insights to share by any chance? This way I could fix if the issue actually relates to my changes. Thanks

[rileykarson]

I didn't find any signal yesterday- opened https://github.com/GoogleCloudPlatform/magic-modules/pull/10419 to see if I can trigger the same failures with a diff. change.

[rileykarson]

No failure- I am just gonna rerun these tests, the failure doesn't make much sense. It's a diff on automatic_scaling, which this doesn't touch.

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+)) google-beta provider: Diff ( 5 files changed, 33 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 7 files changed, 25 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3570 Passed tests: 3186 Skipped tests: 369 Affected tests: 15

Click here to see the affected service packages

all service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample|TestAccAppEngineDomainMapping_update|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccDataprocJobIamPolicy|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccSqlUser_postgresIAM

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataprocJobIamPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_update[Error message] [Debug log] TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[gwendal-lecren]

Hello @rileykarson - So it seems my changes bring a regression somehow. Would you have any details about the errors we are running into? Thanks

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+)) google-beta provider: Diff ( 5 files changed, 33 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 7 files changed, 25 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3578 Passed tests: 3201 Skipped tests: 363 Affected tests: 14

Click here to see the affected service packages

all service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample|TestAccAppEngineDomainMapping_update|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccHealthcareDatasetIamPolicy|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccHealthcareDatasetIamPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_update[Error message] [Debug log] TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[rileykarson]

These test failures are unrelated to your change it turns out, and are failing in nightlies when we always call live APIs. https://github.com/hashicorp/terraform-provider-google/issues/17531 and a bug to-be-filed for the IAP ones. My test of the tests was using the old results still- I'll resolve 'em out of band, our recording system will start using these results if I merge as-is.

[rileykarson]

(If I haven't gotten back to this in a couple days after that fix, ping me by commenting here)

[rileykarson]

https://github.com/GoogleCloudPlatform/magic-modules/pull/10476 is merged. I don't think there's any conflicts so no need to rebase or anything, or CI does that if it can (and fails if it can't due to conflicts)

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+)) google-beta provider: Diff ( 5 files changed, 33 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 7 files changed, 25 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3600 Passed tests: 3222 Skipped tests: 364 Affected tests: 14

Click here to see the affected service packages

all service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample|TestAccAppEngineDomainMapping_update|TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Debug log] TestAccAppEngineServiceNetworkSettings_update[Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Debug log] TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample[Error message] [Debug log] TestAccAppEngineDomainMapping_update[Error message] [Debug log] TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+), 23 deletions(-)) google-beta provider: Diff ( 6 files changed, 55 insertions(+), 26 deletions(-)) terraform-google-conversion: Diff ( 7 files changed, 25 insertions(+), 30 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field ssl_settings lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

[rileykarson]

override-breaking-change: Optional + Computed is a superset of the previous DiffSuppressFunc.

[modular-magician]

Tests analytics

Total tests: 3616 Passed tests: 3248 Skipped tests: 364 Affected tests: 4

Click here to see the affected service packages

all service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineDomainMapping_appEngineDomainMappingBasicExample|TestAccAppEngineDomainMapping_update|TestAccAppEngineFlexibleAppVersion_update|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work