magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update the GCF resource to reflect transition from Container Registry to Artifact Registry

Open Ectelion opened this issue 4 months ago • 3 comments

The general transition from Container Registry is outlined in this public doc. The GCF-specific API transition has already completed. The field docker_registry was already marked as optional and computed -- no need for any explicit changes to the defaulting logic here, we only update the docs and comments to reflect the new auto-defaulting.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: Updated docs for Cloud Function's `docker_registry` field to reflect the change of default from Container Registry to Artifact Registry.

Ectelion avatar Feb 27 '24 10:02 Ectelion

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 27 '24 10:02 github-actions[bot]

/gcbrun

rileykarson avatar Feb 29 '24 22:02 rileykarson

Running tests to make sure there are no surprises, but lgtm assuming there's none

rileykarson avatar Feb 29 '24 23:02 rileykarson

@rileykarson thanks!

Ectelion avatar Mar 01 '24 03:03 Ectelion

/gcbrun

Ectelion avatar Mar 01 '24 03:03 Ectelion