Made base transport layer force ipv4 usage if ipv6 is not supported

[melinath]

Fixes https://github.com/hashicorp/terraform-provider-google/issues/6782

Workaround for https://github.com/golang/go/issues/25321

Note that while I was able to reproduce the Go issue, I was not able to reproduce the TF issue - there seems to be some amount of randomness in terms of when it presents. However, this seems to be the best option for working around the issue.

This PR also removes a lot of complexity that was previously implicitly part of our transport setup via transport.NewHTTPClient and that was mostly unused. (I traced through the code to boil it down to the ~10 or so~ 6 lines we were actually using.)

yaqs/47302089738551296

Release Note Template for Downstream PRs (will be copied)

provider: Forced HTTP requests to use ipv4 on systems with ipv6 disabled, such as Cloud Shell.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 47 insertions(+), 5 deletions(-)) google-beta provider: Diff ( 1 file changed, 47 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3606 Passed tests: 3242 Skipped tests: 364 Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[melinath]

Some real test runs, in case VCR bypasses this change: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_PUBSUB/135875?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true

[rileykarson]

Adding @ScottSuarez as a mandatory reviewer- we should ensure that MTLS is not broken as a result of this change.

[c2thorn]

Do we want a provider-wide changelog note?

[melinath]

Do we want a provider-wide changelog note?

added

[c2thorn]

Do we want a provider-wide changelog note?

added

We are expecting some user-facing impact right? Specifically user's facing https://github.com/hashicorp/terraform-provider-google/issues/6782 will now have their ipv4 settings honored?

[melinath]

Do we want a provider-wide changelog note?

added

We are expecting some user-facing impact right? Specifically user's facing hashicorp/terraform-provider-google#6782 will now have their ipv4 settings honored?

🤦 yep. yep. we sure are. fixed.

[melinath]

Unfortunately the "just override the transport's dialcontext" approach is not feasible because the base transport is wrapped a few times and two of them use private fields to store the wrapped RoundTripper.

[melinath]

yaqs/5034757202074664960

[melinath]

I'm going to attempt to get this change made in google-api-go-client

[melinath]

Opened https://github.com/googleapis/google-api-go-client/pull/2549

[github-actions[bot]]

@melinath, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[rileykarson]

Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs last updated over 3 months ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.