Add instanceFlexibilityPolicy to google_compute_region_instance_group…

[chayankumar999]

Add instanceFlexibilityPolicy to google_compute_region_instance_group_manager to create instances by instanceSelections

compute: added `instance_flexibility_policy` fields to `google_compute_region_instance_group_manager` resource

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[askubis]

One more comment: we're missing documentation from here.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 33 insertions(+), 1 deletion(-)) google-beta provider: Diff ( 4 files changed, 348 insertions(+), 2 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 916 Passed tests: 819 Skipped tests: 72 Affected tests: 25

Click here to see the affected service packages

• compute

Action taken

Found 25 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccRegionInstanceGroupManager_APISideListRecordering|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Error message] [Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Error message] [Debug log] TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Error message] [Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Error message] [Debug log] TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log] TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log] TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log] TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log] TestAccComputeRegionAutoscaler_update[Error message] [Debug log] TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Error message] [Debug log] TestAccComputeRegionBackendService_withBackendInternalManaged[Error message] [Debug log] TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log] TestAccComputeRegionPerInstanceConfig_statefulIps[Error message] [Debug log] TestAccComputeRegionPerInstanceConfig_update[Error message] [Debug log] TestAccRegionInstanceGroupManager_APISideListRecordering[Error message] [Debug log] TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log] TestAccRegionInstanceGroupManager_basic[Error message] [Debug log] TestAccRegionInstanceGroupManager_distributionPolicy[Error message] [Debug log] TestAccRegionInstanceGroupManager_instanceFlexibilityPolicy[Error message] [Debug log] TestAccRegionInstanceGroupManager_resourceManagerTags[Error message] [Debug log] TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log] TestAccRegionInstanceGroupManager_targetSizeZero[Error message] [Debug log] TestAccRegionInstanceGroupManager_update[Error message] [Debug log] TestAccRegionInstanceGroupManager_versions[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[rileykarson]

        Error: Error creating RegionInstanceGroupManager: googleapi: Error 400: Invalid value for field 'resource.instanceFlexibilityPolicy': ''. Setting instance flexibility policy is not allowed., invalid

[chayankumar999]

A short note: This task has been paused for a unwanted issue with the patch update and also for priority change. Will started working on it again before GA launch hopefully.

[rileykarson]

Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs in "Draft" last updated over a month ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.