magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

adding new tests for compute.googleapis.com/UrlMap

Open kotarsky opened this issue 9 months ago • 2 comments

adding new tests for compute.googleapis.com/UrlMap

compute: added tests field to `compute.googleapis.com/UrlMap` resource

kotarsky avatar Apr 26 '24 17:04 kotarsky

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 26 '24 17:04 github-actions[bot]

There's a mismatch between the release note and PR title and the change you've made. Do you have a bug or issue you can link for context?

You're right, just edited the release note and fixed it. Actually, I'm just working on some tests related to some assets. You can expect more PRs from me in the next few days. Thanks for the review!

kotarsky avatar Apr 30 '24 11:04 kotarsky

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 75 insertions(+))

modular-magician avatar May 07 '24 20:05 modular-magician

/gcbrun

dvfons avatar May 14 '24 01:05 dvfons

@dvfons: I'm seeing a CLA issue on your new commit, can you resolve that? Thanks!

rileykarson avatar May 14 '24 16:05 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 75 insertions(+))

modular-magician avatar May 14 '24 16:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 75 insertions(+))

modular-magician avatar May 16 '24 17:05 modular-magician

all tests fixed

kotarsky avatar May 16 '24 18:05 kotarsky

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 78 insertions(+))

modular-magician avatar May 16 '24 21:05 modular-magician

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 20 '24 09:05 github-actions[bot]

@rileykarson Can you review it again?

kotarsky avatar May 21 '24 11:05 kotarsky

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 78 insertions(+))

modular-magician avatar May 22 '24 16:05 modular-magician

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 27 '24 09:05 github-actions[bot]