Vivek Goyal

Results 97 comments of Vivek Goyal

@cgwalters I have pushed patches again after taking care of review comments. I have added libdss.sh now but I have not added any test cases. That can come later.

Are you testing the latest code?

I can't reproduce it.

Oh you specified extra S, I can see it.

Ok, this overrides that internal variable STORAG_DRIVERS and that's the problem.

@rhatdan may be we should source the external files first and then define internal global variables to make sure users can't intentionally/accidentally override container-storage-setup gloabal variables?

@rhatdan I am playing with another patch where I want to initialize global variables after sourcing config file. That way all the globals will be protected.

I think I have taken care of that in my patch. Have a look.

This is called both for docker and non-docker setups. So function name should be changed too.