Vivek Goyal

@moolitayer I think you don't have sufficient space in volume group `vg0`. You an run command `vgs` and that should show you how much free space is there. You can...

This needs to be fixed in atomic installer to leave free space by default in volume group so that docker-storage-setup can setup a thin pool out of the box for...

@shishir-a412ed is cleaning up @mvollmer patch to remove hard coded assumptions about partition name being '${dev}1'. Once that patch gets merged, this problem should be solved.

So if you have a separate partition, you can simple create a volume group with that partition and pass that volume group to docker-storage-setup? Say you have /dev/vdc1 partition free....

Well, docker-storage-setup will fail. But current docker is written in such a way that it has Wants= dependency on docker-storage-setup and not Requires= dependency. We can change that but then...

May be we need to convert this into Requires= dependency so that if docker-storage-setup fails, docker fails too. And provide an option where upon failure, user can edit /etc/sysconfig/docker-storage-setup and...

Hmm..., so basically if user decided to override any of the defaults using /etc/sysconfig/docker-storage-setup, we don't want docker to start if docker-storage-setup fails? Currently atomic specifies GROWPART=yes in /etc/sysconfig/docker-storage-setup. That...

I feel that if we provide user an easy way to opt-in for loop devices (if lvm thin pool setup failed), then it might be ok to fail docker out...

I think this patch series can go in as it is. What do to when storage-setup fails is a separate discussion and I will open a new issue to track...

Ok, I opended issue #62 to discuss this issue.