container-storage-setup icon indicating copy to clipboard operation
container-storage-setup copied to clipboard
verified publisher icon projectatomic

get_docker_storage_options() should be generalized for inputfile case too

Open rhvgoyal opened this issue 8 years ago • 3 comments

get_docker_storage_options() still seem to be hardcoding DOCKER_STORAGE_OPTIONS. And this will not work for general container storage setup.

rhvgoyal avatar Mar 01 '17 21:03 rhvgoyal

@rhatdan CC

rhvgoyal avatar Mar 01 '17 21:03 rhvgoyal

We are not supposed to be calling get_docker_storage_options for non docker-storage-setup environments. Which is why we change the STORAGE_OPTIONS to DOCKER_STORAGE_OPTIONS when we use /etc/sysconfig/docker-storage-setup.

rhatdan avatar Mar 01 '17 21:03 rhatdan

This is called both for docker and non-docker setups. So function name should be changed too.

rhvgoyal avatar Mar 01 '17 22:03 rhvgoyal