Vivek Goyal comments

Results 97 comments of


                                            Vivek Goyal

Add option to add more options to docker storage

cc @shishir-a412ed Would you like to propose enabling deferred removal and deferred deletion by default upstream?

Fix: 002-test-reject-disk-with-lvm-signature.sh

@shishir-a412ed can you rebase this PR on top of latest tree.

Fix: 002-test-reject-disk-with-lvm-signature.sh

@shishir-a412ed Can you please take care of minor comments.

Fix: 002-test-reject-disk-with-lvm-signature.sh

I think we can modify remove_pvs() to remove pvs both from partition and disk if pv exists. So we can implement a function pv_exists() and if pv exists, remove it....

Mount leak in platform_supports_deferred_deletion()

Ed, in your case which line is returning without mounting? 143 or 148?

Mount leak in platform_supports_deferred_deletion()

cc @lsm5

Mount leak in platform_supports_deferred_deletion()

yep, I am fixing that now

setup left in an unrecoverable state

@bpbp-boop Messages you have output are truncated. Try using "-l". So what's the problem you are facing? I did not understand it yet.

Changed is_block_dev_partition() to allow raid devices

@andreas-wilm I just committed a similar patch for multipath. Is a partition on top of raid repoted as type "part" by lsblk? Can you give me instructions on how to...

Fix selinux file labels when set CONTAINER_ROOT_LV_MOUNT_PATH to a directory other than /var/lib/docker

@rhatdan Do you know what needs to be done here?