Vivek Goyal

Results 97 comments of Vivek Goyal

I have no idea what issues will be caused if we use --force. I am wondering should we switch to "parted" instead of sfdisk or use a different type of...

So this seems to come from MBR as there maximum partition size can be 2TB. (for 512 byte sector). Should we consider using GPT. I am not sure if there...

@cgwalters Why do we need to partition the disk at all? Why can't we add it directly to volume group.

Actually even with raw disks, we might add it to root volume group (if VG= was not specified) and over next reboot we might have to grow that partition using...

sounds like a good idea.

We should do that for generic description of different backends. But that documentation does not cover docker-storage-setup details. So if there is any information we want to detail which is...

I think we should check the size of disk and if it is more than 2TB, create GPT table otherwise fallback to msdos type table. That way we will not...

Can you put "Signed-off-by". Also I see 3 commits in your branch. Is that your intention? I thought only topmost commit is relevant. If that's the case why not create...

@eburgueno if patch is small enough, then one patch is good. But if single patch is become too big then I prefer that it is broken down into multiple patches....

@eburgueno W.r.t Signed-off-by, I am still trying to figure out what should be our conventions. For now if you can just put your signed off by, that would work. `Signed-off-by:...