container-storage-setup One bad config is not ignored

Use STORAGE_DRIVERS=overlay2 instead of correct STORAGE_DRIVER will result in some unexpected error messages.

# docker-storage-setup ERROR: Invalid storage driver: devicemapper.

Mar 01 '17 15:03 ghost

Are you testing the latest code?

Mar 01 '17 15:03 rhvgoyal

I can't reproduce it.

Mar 01 '17 16:03 rhvgoyal

Oh you specified extra S, I can see it.

Mar 01 '17 16:03 rhvgoyal

Ok, this overrides that internal variable STORAG_DRIVERS and that's the problem.

Mar 01 '17 16:03 rhvgoyal

@rhatdan may be we should source the external files first and then define internal global variables to make sure users can't intentionally/accidentally override container-storage-setup gloabal variables?

Mar 01 '17 16:03 rhvgoyal

https://github.com/projectatomic/container-storage-setup/pull/217

Mar 01 '17 16:03 rhatdan

@rhatdan I am playing with another patch where I want to initialize global variables after sourcing config file. That way all the globals will be protected.

Mar 01 '17 19:03 rhvgoyal

We can also do that, but it could get confusing. We have globals that can be overridden, as well.

Mar 01 '17 19:03 rhatdan

I think I have taken care of that in my patch. Have a look.

Mar 01 '17 19:03 rhvgoyal