[WIP] C-based harvest in ELM-FATES

[sshu88]

This pull request contains modification in E3SM corresponding to another FATES PR #888. In detail, necessary input to enable FATES C-based harvest from ELM is passed to FATES through bc_in. Output from FATES used to calculate land use emission and net biosphere productivity is passed to ELM through bc_out.

[rljacob]

The PR description should describe the code changes and not just point to another PR description.

[rljacob]

Needs action and review from @sshu88 @rgknox @bishtgautam

[rljacob]

Still needs action and review from @sshu88 @rgknox @bishtgautam

[rljacob]

telecon notes: Waiting for a FATES update before removing WIP.

[rljacob]

telecon notes: still waiting for FATES PR.

[rljacob]

@rgknox this is waiting on a FATES PR and then I guess an update of FATES to E3SM.

[bishtgautam]

@sshu88 You have mistakenly updated multiple submodules in this PR which need to be reverted.

[sshu88]

@bishtgautam @rgknox I have reverted those pointers now. Thanks.

[bishtgautam]

@sshu88 Thanks for fixing the submodules. Is this PR still WIP or ready to be reviewed/merged or waiting for another FATES PR to go first?

cc: @glemieux @rgknox

[bishtgautam]

@sshu88 Is this WIP or ready to be merged?

[sshu88]

@bishtgautam We can go ahead and merge the work once the FATES part is merged.

[glemieux]

@bishtgautam We can go ahead and merge the work once the FATES part is merged.

@bishtgautam I'm working on the final deconflict and test on the fates-side right now.

[rgknox]

The changes just merged into this branch, in https://github.com/E3SM-Project/E3SM/pull/5106/commits/13d0f5a71ebff055ddd3155a13ebcdd69da43ce7 , were originally overlooked, but nonetheless required for compatibility with fates API 25.

[glemieux]

@sshu88 would you remove the "[WIP]" from the title now?

[glemieux]

@bishtgautam we still need to update the pointer to the fates side, but the associated PR hasn't been merged yet. I'll give you a heads up when that happens

[bishtgautam]

Are the existing tests cover the new physics? Or, should we add a new test?

[glemieux]

Are the existing tests cover the new physics? Or, should we add a new test?

We should add new tests, but I would like to defer that to a future PR in which we review and update all of the fates tests for the land developer suite.

[glemieux]

I'm running the land-developer tests and seeing two unexpected failures. I haven't looked into them much yet, but one is a fates smoke test failing during runtime in PhosphorusDynamicsMod and the other is a model build failure for ERS.ne30pg2_r05_EC30to60E2r2.GPMPAS-JRA.cori-haswell_intel.mosart-rof_ocn_2way.

folder location (Cori):

/global/homes/g/glemieux/cori-scratch/e3sm-tests/pr5106-merge.fates.cori-haswell.intel.Ce0716a090f-F25047167

Note I'm using Cori as perlmutter is down right now.

[rgknox]

I submitted some updates to @sshu88 's branch to resolve the issues with the fates_eca test. Tests were passing on Cori. Should update once we get it approved and checked.

[glemieux]

@sshu88 I created a PR to your branch to update the fates pointer now that https://github.com/NGEET/fates/pull/888 is integrated on the fates-side.

@bishtgautam I ran land developer tests on Cori and all the tests except ERS.ne30pg2_r05_EC30to60E2r2.GPMPAS-JRA.gcp12_gnu.mosart-rof_ocn_2way passed (due to https://github.com/E3SM-Project/E3SM/issues/5412).

[glemieux]

@bishtgautam this can be closed per #5429.