Ran Shidlansik

Results 195 comments of Ran Shidlansik

>In Valkey (previous Redis), every command sent by client must go through the network twice -- client send the command, and sever response the command with message or error code....

I agree yielding inside "long-commands" (probably need to consider all commands lack the CMD_FAST flag) is a good option. I think we will have to think what commands we will...

@poiuj overall looks much better now. I would suggest we include some unit tests to cover different types edge cases (for example the case of old style alloc overflow). I...

@poiuj the tests looks fine. Regarding the top comment: >The downside of the adjustment is that with allocators that do not allocate larger than requested chunks (like GNU allocator), we...

> @ranshid your example is correct. It's a 59 bytes gain if we use jemalloc. My top commented is about libc allocator that wouldn't allocate 320 bytes in this case....

@oranagra I updated the top comment. I think we are ready to go (unless you find some unclosed issue I missed)

@oranagra I made some small fix to prevent the race condition in the valgrind tests.

> can you please add some trivial monitor + blocked client test in unit/instospection.tcl? [edit] and make sure the top comment is updated @oranagra. done

> @alon-arenberg can you do what was proposed above? (moving the test to before module init). i.e. add another commit to this PR to replace the code with the other...

Although late for this discussion, would also like to ask some questions about modules SDK. Currently we keep only the [rust module SDK](https://github.com/valkey-io/valkeymodule-rs) under our repository. In case of option...