ramin

feat(core/config): enable override of rpc.host and grpc.host, and add ability to use secure connections

5

- builds upon but largely replaces https://github.com/celestiaorg/celestia-node/pull/3153 and totally replaces https://github.com/celestiaorg/celestia-node/pull/3154 - enabled splitting of RPC config and GRPC config so we can set unique hosts AND ports for each...

enable govet fieldalignment

5

digging through old issues found the request for integrating "structslop" with ci. The tool of which does some struct memory alignment checks. I was surprised this wasn't already present in...

sub task of https://github.com/celestiaorg/celestia-node/issues/2961 which we decided to skip due to test harness complexity still appropriate to take this approach with unit tests and potentially speed up significantly

- TestDiscovery flakey tests intermittently with race detector ``` 2024/01/18 13:37:23 failed to sufficiently increase receive buffer size (was: 208 kiB, wanted: 2048 kiB, got: 416 kiB). See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for...

Adds a step in the ci_and_release pipeline to generate `openrpc.json` using `make openrpc-gen` and store that generated file with the release artifacts. This is set to run after go-releaser, though...

ci(lint): golangci-lint and fieldalignment

4

At suggestion and request of @Wondertan, implemented govet field alignment linting for struct alignment/padding checks, and subsequently committed fixes for them, as we did in https://github.com/celestiaorg/celestia-node/pull/2856 Needed to take a...

Refs #3335 Attempts to create more accurate doc/comments on Get and GetProof in `blob/service.go` to improve legibility and comprehension of how these methods behave to API consumers specifically cc @vgonkivs

Ok, been doing this in small bits over a few weeks and re-arranged the furniture multiple times, so hopefully it is still coherent, but figured it was time stop fiddling...

created at request of @renaynay a few days ago for helping with some testing, opening for consideration to be saved/committed to `cel-shed` for preservation (assuming it will be useful again)

misc(share/p2p): reduce frequency of discovery retries

3

Fixes #3550 as suggested by [guillaumemichel](https://github.com/guillaumemichel). In adjusting the "1 liner" realized there was some relatively funky stuff in tests where we set/reset a package level var for the interval,...