celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

misc(share/p2p): reduce frequency of discovery retries

Open ramin opened this issue 1 year ago • 3 comments

Fixes #3550 as suggested by guillaumemichel. In adjusting the "1 liner" realized there was some relatively funky stuff in tests where we set/reset a package level var for the interval, so moved both AdvertiserRetryTimeout and DiscoveryRetryTimeout to parameters and allowed customization where NewDiscovery is called. Also adjusted some of the intervals to be faster in tests so they execute within the test context Timeout and thus, hopefully will fix #3115

ramin avatar Jul 11 '24 11:07 ramin

There is some wisdom behind the metaphor in ca67fef50f89af5cbbc1b4ebfebc40f733ddae92, but I am not getting it

Wondertan avatar Jul 22 '24 12:07 Wondertan

There is some wisdom behind the metaphor in ca67fef, but I am not getting it

@Wondertan ah, I put it back how it was, so no unnecessary change :-)

ramin avatar Jul 22 '24 13:07 ramin

Let's hold off on this til we get conf from v0.14.1

renaynay avatar Jul 29 '24 13:07 renaynay