Randy Döring

Sorry for the late feedback. I took a quick look and I have some concerns: - Using `sys.args` at this place doesn't seem right. - There are not only two...

Can you give more detail on why this fix is required, a concrete use-case for example? The linked issue has been closed by another pull request that introduced an `allows`...

It seems this one has been duplicated by #451, which got merged without a test. (Sorry about that.) Later I added the missing test (and some more) in #453. Thus,...

Further, according to PEP 440 local version identifiers are not permitted in [inclusive](https://peps.python.org/pep-0440/#inclusive-ordered-comparison) and [exclusive](https://peps.python.org/pep-0440/#exclusive-ordered-comparison) ordered comparisons. Thus, the tested constraints are invalid according to PEP 440. If this behavior...

I didn't want to delay this PR any further and had to think about gracefully handling directory dependencies (because both file dependency and directory dependency use the key `path` in...

> Since there are breaking changes here, I'll let core members review the PR, but it looks like sensible improvements to me, especially prohibiting bump when we can't guess the...

@dimbleby Please don't delete your branch until we don't depend on it in poetry anymore.

> I'll restate my concern about the following even if this PR won't deal with it. The class has some semver related methods (like `next_breaking`) but apart from that it's...

I can't reproduce this yet. In general, the markers are not required in the lockfile to choose the correct version for installation. @john-sandall Can you share your pyproject.toml and poetry.lock?...

Without having the difference between poetry's `Factory` class and poetry-core's base `Factory` class investigated further, what I don't like is the amount of code duplication if the change is made...