Randy Döring

Results 309 comments of Randy Döring

I will try to describe my understanding. Please correct me if some of my assumptions are wrong. If I understand correctly, the only use case to skip all path dependencies...

> Yes this is only about path dependencies > [...] > * I don’t know of any workflow that would benefit from skipping file dependencies My point is that a...

`--no-path-directory` seems a bit redundant. I like `--no-directory` better. Maybe, just `--no-dir`. (There is a method `is_dir()` in `pathlib`, so this can be considered a common abbreviation.)

If I understand correctly, the main motivation for this feature is the Docker cache. Before taking a look into the implementation details, I'd like to here the opinions of other...

It's not a full update due to the whitelist: https://github.com/python-poetry/poetry/blob/ef89e90fc1305e07a62e9e715c91a66c8d7425f7/src/poetry/console/commands/add.py#L260 An example (pyproject.toml/poetry.lock) where your change matters would be really helpful.

Yes, the logic is confusing and could require a refactoring but maybe a small change is enough to fix this issue: After taking a quick look, I believe you have...

A possible solution to fix the printing might be to replace the condition in https://github.com/python-poetry/poetry/blob/860c83872b7d93a25acfb331ccf1d00ebf2e302a/src/poetry/installation/installer.py#L294 ```diff - if self._lock and self._update: + if not (self._execute_operations or self._dry_run): ```

Updated the title. We don't need a `no-update` flag because that's what `poetry add` should do no matter if you run it with or without `--lock`.

``` test_info_setup_missing_mandatory_should_trigger_pep517[name] ``` It's the test case with the missing name in `setup.py`. ``` error: Invalid distribution name or version syntax: poetry-config-5k08imt--0.1.0 ``` Is it possible that the name of...

It seems that the failure is really caused by this PR: After setting a breakpoint at https://github.com/python-poetry/poetry/blob/5a9da19fa85631f46a5f1edc9e61c2b65255dab2/tests/inspection/test_info.py#L236 I noticed that `source_dir` is empty without this PR, but contains two directories...