Randy Döring

Results 300 comments of Randy Döring

I would probably postpone this until after Poetry 1.8. The platformdirs 3.0 release was about a year ago and the concerning Poetry release a little bit later. Besides, the code...

What should the user interface look like? I assume this requires a new field in the dependency specification in pyproject.toml? Or can it be a general setting that is applied...

It would be even better if it was not created in the tests fixtures directory in the first place because it could influence subsequent calls of the test. In other...

I'm not sure about the right path. Intuitively, I had the same expectation as you. However, according to the [pathlib PEP](https://peps.python.org/pep-0428/#sane-behaviour): > Many os.path functions are tied by backwards compatibility...

> Not sure about the changes in site_packages.py, if importlib-metadata doesn't promise to return a `Path` then I'd have thought the code was fine as it was? `importlib-metadata` promises to...

Makes sense. Some nitpicks: > [...] your package contains a folder [...] [...] your project contains a folder [...] (the folder is the package) or maybe "package" is also correct...

> Poetry also remove everything below that in this process -- the `[tool.isort]` and `[tool.black]` sections are lost. Thanks for reporting this. I fixed it and added a test. >...

Yes, we should take a look at all of the deprecated command line options.

Looks like the file is created/used only by the [install script](https://github.com/python-poetry/install.python-poetry.org/blob/d62875fc05fb20062175cd14d19a96dbefa48640/install-poetry.py#L512). Afaik Poetry itself does not know anything about a `VERSION` file so it cannot update the version in its...

I do not use the poetry pre-commit hooks myself, but trying it I can confirm that this hook seems broken - and I wonder how/if it has ever worked.