poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

Published 20 hours ago • verified publisher icon python-poetry

versions: preserve any local label when bumping

Open abn opened this issue 2 years ago • 3 comments

Split out of #379

abn avatar Jun 12 '22 14:06 abn

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Jun 12 '22 14:06 sonarcloud[bot]

What is this fixing?

I don't think it's obvious what the "right" behaviour is, or even that there is a single right behaviour

  • eg users of poetry version might - or might not - want this updated behaviour
  • there are internal places that call next_minor() and next_major() as part of version comparison, does this change help or hurt them?

dimbleby avatar Jun 13 '22 08:06 dimbleby

Further, according to PEP 440 local version identifiers are not permitted in inclusive and exclusive ordered comparisons. Thus, the tested constraints are invalid according to PEP 440. If this behavior is required for some reason, we should at least add a comment explaining why it's required.

radoering avatar Jun 13 '22 17:06 radoering